Skip to content

Add ConditionalGraphicsView #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Kyle-Ye merged 3 commits into from
Jan 17, 2026
Merged

Add ConditionalGraphicsView #722

Kyle-Ye merged 3 commits into from
Jan 17, 2026
+160 −1

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Jan 17, 2026

No description provided.

@augmentcode
Copy link

augmentcode bot commented Jan 17, 2026

🤖 Augment PR Summary

Summary: This PR introduces a new SPI protocol to support views that can switch between a regular body and an alternate graphics-renderer body.

Changes:

  • Added ConditionalGraphicsView (SPI, v6+) with a graphicsBody result-builder property.
  • Introduced a new ViewInput flag (UsingGraphicsRenderer) and convenience accessors across _GraphInputs/_ViewInputs/_ViewListInputs/_ViewListCountInputs.
  • Implemented _makeView, _makeViewList, and _viewListCount to choose between Body and GraphicsBody based on usingGraphicsRenderer.
  • Added ConditionalGraphValue as a small wrapper to route rendering to the selected body type.
  • Added GraphicsViewBodyAccessor to build/update graphicsBody while reusing the existing dynamic-property buffer tracing pipeline.
  • Adjusted the core View protocol requirement from var body: Self.Body to var body: Body (same associated type, simpler signature).

Technical Notes: Switching is driven entirely by the usingGraphicsRenderer input, and dynamic property mounting is traced for whichever body variant is selected.

🤖 Was this summary useful? React with 👍 or 👎

augmentcode[bot]
augmentcode bot reviewed Jan 17, 2026
View reviewed changes
Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@codecov
Copy link

codecov bot commented Jan 17, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.58%. Comparing base (eece8ed) to head (4130177).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...OpenSwiftUICore/View/ConditionalGraphicsView.swift 0.00% 54 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #722      +/-   ##
==========================================
- Coverage   28.61%   28.58%   -0.04%     
==========================================
  Files         598      599       +1     
  Lines       36390    36444      +54     
==========================================
+ Hits        10414    10416       +2     
- Misses      25976    26028      +52

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye merged commit 3916a7c into main Jan 17, 2026
6 of 8 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/conditional_graphicsview branch January 17, 2026 11:18
@Kyle-Ye Kyle-Ye linked an issue Jan 17, 2026 that may be closed by this pull request
Add Image support #727
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@augmentcode augmentcode[bot] augmentcode[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Image support

2 participants

@Kyle-Ye